-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#33574Closed
Copy link
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallywaiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
All of the non-firebase tests in the Scenario app (see instruction removal in linked PR below) are broken. This happened over the course of time, where the target was incorrectly set up on CI so that failures were not reported, and now failures are just ignored. I have never successfully run these tests locally, and it's not clear to me when they last passed.
@blasten was looking at whether it would be better to just port these to the framework side, where we have better options for taking screenshots.
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallywaiting for PR to land (fixed)A fix is in flightA fix is in flight