-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: animationAnimation APIsAnimation APIsf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.perf: memoryPerformance issues related to memoryPerformance issues related to memoryplatform-androidAndroid applications specificallyAndroid applications specificallyplatform-fuchsiaFuchsia code specificallyFuchsia code specifically
Description
Received some memory metrics regression during landing the #82670 . Related to #88480 .
We introduced the DualTransitionBuilder internally in #58686 and it's only for the zoom page transition currently. When there are two routes interacting in the tree, we'll get at least two sealed transitions including 2 scales and 2 fades plus 1 opacity transforms. Although some part of them won't triggered during the enter/exit action, it might address some memory metrics increased.
A potential solution is to roll back with two AnimationBuilders, not sure if it'll break original tests or not.
deckerst
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: animationAnimation APIsAnimation APIsf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.perf: memoryPerformance issues related to memoryPerformance issues related to memoryplatform-androidAndroid applications specificallyAndroid applications specificallyplatform-fuchsiaFuchsia code specificallyFuchsia code specifically