-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team
Description
In flutter/plugins#4206 we are turning on Android linting, but it does not attempt to fix existing issues. Instead, all existing issues have been codified into lint-baseline.xml so that any new issues will be caught by CI.
We should go plugin by plugin and fix (or explicitly disable in a targetted way) all of the issues, and remove both lint-baseline.xml, and the corresponding baseline file("lint-baseline.xml") from build.gradle.
The plugins to be cleaned up are:
- camera_android - [camera_android] Fix Android lint warnings packages#3716, [camera] Fix Android lint issues packages#3993
- camera_android_camerax - [camera] Fix Java lints in camerax version packages#3966
- espresso
- flutter_plugin_android_lifecycle - [flutter_plugin_android_lifecycle] Fix lints packages#4030
- google_maps_flutter_android - [google_maps_flutter_android] Fix Android lint warnings packages#3751
- google_sign_in_android - [google_sign_in] Fix Android Java warnings packages#3762
- image_picker_android - [image_picker] Fix Android lints packages#3887
- in_app_purchase_android - [in_app_purchase] Fix Java lints packages#4032
- local_auth_android - [local_auth_android] Fix Android lint warnings packages#3764
- path_provider_android - [path_provider] Fix Android lint warnings packages#3706
- quick_actions_android - [quick_actions] Fix Android lint issues packages#3885
- shared_preferences_android - [shared_preferences] Remove Android lint baseline packages#3707
- url_launcher_android - [url_launcher] Fix Android Java warnings packages#3690
- video_player_android - [video_player] Fix Android lints packages#3886
- webview_flutter_android - [webview_flutter_android] Fix Android lint warnings packages#3675
[Edit: Updated the list with more plugins since https://github.com/flutter/packages/pull/3648 adds more baseline files]
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team