Repository navigation
[web] text_test semantics tests fails on web. #87877
Description
Part of the skip test audit. The test:
Are currently skipped on the web. If we reenable them they fail with variations of:
% flutter test --platform=chrome --web-renderer=html test/widgets/text_test.dart
00:03 +14 ~1: inline widgets generate semantic nodes
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
Expected: semantics node matching:
TestSemantics(
id: 0,
rect: Rect.fromLTRB(0.0, 0.0, 2400.0, 1800.0),
elevation: 0,
thickness: 0,
children: <TestSemantics>[
TestSemantics(
transform:
[0] 3,0,0,0
[1] 0,3,0,0
[2] 0,0,1,0
[3] 0,0,0,1,
children: <TestSemantics>[
TestSemantics(
label: 'a ',
textDirection: TextDirection.ltr,
children: <TestSemantics>[
],
),
TestSemantics(
flags: <SemanticsFlag>[SemanticsFlag.isLink],
actions: <SemanticsAction>[SemanticsAction.tap],
label: 'pebble',
textDirection: TextDirection.ltr,
children: <TestSemantics>[
],
),
TestSemantics(
label: ' in the ',
textDirection: TextDirection.ltr,
children: <TestSemantics>[
],
),
TestSemantics(
label: 'INTERRUPTION',
textDirection: TextDirection.rtl,
children: <TestSemantics>[
],
),
TestSemantics(
label: 'sky',
textDirection: TextDirection.ltr,
children: <TestSemantics>[
],
),
],
),
],
)
Actual: SemanticsTester:<SemanticsTester for SemanticsNode#0(Rect.fromLTRB(0.0, 0.0, 2400.0,
1800.0))>
Which: expected node id null to have 5 children but found 4.
Current SemanticsNode tree:
SemanticsNode#0
│ Rect.fromLTRB(0.0, 0.0, 2400.0, 1800.0)
│
└─SemanticsNode#1
│ Rect.fromLTRB(0.0, 0.0, 800.0, 600.0) scaled by 3.0x
│
├─SemanticsNode#3
│ Rect.fromLTRB(-4.0, 22.0, 32.0, 44.0)
│ label: "a "
│ textDirection: ltr
│ sortKey: OrdinalSortKey#ccf5f(order: 0.0)
│
├─SemanticsNode#4
│ Rect.fromLTRB(24.0, 22.0, 116.0, 44.0)
│ actions: tap
│ flags: isLink
│ label: "pebble"
│ textDirection: ltr
│ sortKey: OrdinalSortKey#b6c7e(order: 1.0)
│
├─SemanticsNode#5
│ Rect.fromLTRB(108.0, 22.0, 228.0, 44.0)
│ label: " in the "
│ textDirection: ltr
│ sortKey: OrdinalSortKey#4ce03(order: 2.0)
│
└─SemanticsNode#2
Rect.fromLTRB(224.0, 0.0, 244.0, 40.0)
tags: PlaceholderSpanIndexSemanticsTag(0)
label: "INTERRUPTION"
textDirection: rtl
thickness: 1.0
The semantics tree would have matched the following configuration:
TestSemantics.root(
children: <TestSemantics>[
TestSemantics(
id: 1,
children: <TestSemantics>[
TestSemantics(
id: 3,
label: 'a ',
textDirection: TextDirection.ltr,
),
TestSemantics(
id: 4,
flags: <SemanticsFlag>[SemanticsFlag.isLink],
actions: <SemanticsAction>[SemanticsAction.tap],
label: 'pebble',
textDirection: TextDirection.ltr,
),
TestSemantics(
id: 5,
label: ' in the ',
textDirection: TextDirection.ltr,
),
TestSemantics(
id: 2,
tags: <SemanticsTag>[const
SemanticsTag('PlaceholderSpanIndexSemanticsTag(0)')],
label: 'INTERRUPTION',
textDirection: TextDirection.rtl,
),
],
),
],
)
When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 251:49 throw_
../packages/test_api/src/expect/async_matcher.dart.js 164:22 fail
../packages/test_api/src/expect/async_matcher.dart.js 159:12 _expect
../packages/test_api/src/expect/async_matcher.dart.js 86:12 expect$
../packages/flutter_test/src/deprecated.dart.js 7250:12 expect$
text_test.dart.js 2877:23 <fn>
If this is not a bug, but intentional, just add a comment with an [intended] tag to indicate that this should always be skipped.
flutter doctor
[✓] Flutter (Channel master, 2.5.0-6.0.pre.28, on macOS 11.5.1 20G80 darwin-x64, locale en)
• Flutter version 2.5.0-6.0.pre.28 at /Users/darrenaustin/dev/flutter
• Upstream repository [email protected]:flutter/flutter.git
• Framework revision d3bdbed498 (20 hours ago), 2021-08-06 17:45:02 -0700
• Engine revision c0e59bc7b6
• Dart version 2.14.0 (build 2.14.0-383.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at /Users/darrenaustin/Library/Android/sdk
• Platform android-30, build-tools 30.0.2
• ANDROID_SDK_ROOT = /Users/darrenaustin/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.5.1, Build version 12E507
• CocoaPods version 1.10.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.0)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 48.1.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.2)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin version 59.0.4
• Dart plugin version 212.4746.57
[✓] VS Code (version 1.58.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.24.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 11.5.1 20G80 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 92.0.4515.131
• No issues found!
Activity
[-][web] text_test 'WidgetSpans with no semantic information are elided from semantics' test fails on web.[/-][+][web] text_test semantics tests fails on web.[/+]flutter-triage-bot commentedon Aug 16, 2023
This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
yjbanov commentedon Sep 2, 2023
The test is still skipped.
flutter-triage-bot commentedon Jan 22, 2024
This issue is marked P1 but has had no recent status updates.
The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.
Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!
[web] Unskip 12 passing framework tests in text_test and opacity_test (…