-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: animationAnimation APIsAnimation APIsa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Description
Related to this change: #86912 and subsequent reverts/relands
The golden file test animation.LiveBinding.press.animation appears to be producing a new image almost every day.
See image results for the last week in gold:
Each dot along the line is a commit in flutter/flutter, they are interactive and link to pull requests. Each color dot represents a different image. Clicking on the hash in the color key will show you the image.
Since the above change, the test has reported a new image almost every day across multiple machines.
The other related test appears to be stable that can be viewed here:
- https://flutter-gold.skia.org/search?corpus=flutter&include_ignored=false&left_filter=name%3Danimation.LiveBinding.press.animation.2&max_rgba=0&min_rgba=0&negative=true¬_at_head=false&positive=true&reference_image_required=false&right_filter=&sort=descending&untriaged=true
I came across this while running tests locally on my machine, I am using a Mac at TOT and continually failing this golden file test.
Will file a PR to skip the test until the flake is resolved.
FYI @dkwingsmt
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: animationAnimation APIsAnimation APIsa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team