Skip to content

Engine pre-commit hooks don't work on windows #86506

@jonahwilliams

Description

@jonahwilliams

From flutter/engine#26699

A few issues I've run into.

  • usr/bin/env is not where python3 is typically installed on a windows machine, so the shebang line causes a permission error.
  • Beyond that, the scripts seem to have some other Exec Format Error.
  • running the scripts manually with python3 leads to:
    • fatal: Not a valid object name FETCH_HEAD
    • clang-tidy job failed to run. (due to the paths for clang tidy being incorrect?)

I worked around this by disabling githooks for the repo.

@dnfield @zanderso

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions