Skip to content

iOS engine artifacts Flutter.xcframework contains old architecture triples directories #85062

Closed

Description

@jmagman

As of #85052 the Flutter engine iOS artifacts contain iOS ARM simulator binaries, and the Flutter.xcframework should only contain a ios-arm64_x86_64-simulator directory. It also was built on Xcode 12, so the ios-armv7_arm64 directory has been renamed ios-arm64_armv7. However, because the artifact downloads do not remove old directories from the bundle, the old and new architecture triple directories exist next to each other.

Steps to reproduce

$ git checkout stable
$ flutter precache
$ git checkout a2fa6d4 # master as of https://github.com/flutter/flutter/pull/85052
$ flutter precache
$ ls bin/cache/artifacts/engine/ios/Flutter.xcframework

Expected

ios-arm64_armv7
ios-arm64_x86_64-simulator

Actual

ios-arm64_armv7
ios-arm64_x86_64-simulator
ios-armv7_arm64
ios-x86_64-simulator

Activity

  1. jmagman commented on Jun 22, 2021

    @jmagman
    MemberAuthor

    This is blocking iOS ARM simulator adoption. The incorrect simulator directory happens to be selected when I test #85059 on an M1 ARM Mac.

  2. added
    platform-iosiOS applications specifically
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Jun 22, 2021
  3. changed the title [-]iOS engine artifacts Flutter.xcframework contains old architecture triples[/-] [+]iOS engine artifacts Flutter.xcframework contains old architecture triples directories[/+] on Jun 22, 2021
  4. jmagman commented on Jun 22, 2021

    @jmagman
    MemberAuthor

    More urgently than iOS ARM simulator adoption, if the tool prefers embedding the Xcode 11 style ios-armv7_arm64 over the Xcode 12 ios-arm64_armv7 then the engine will remain out of date and won't be built with the newer cached dart.

  5. self-assigned this
    on Jun 22, 2021
  6. jmagman commented on Jun 22, 2021

    @jmagman
    MemberAuthor

    See also #74818. The fix at #74818 didn't address this.
    When this reproduced

    /// Unzipping multiple file into a directory will not remove old files
    /// from previous versions that are not present in the new bundle.
    final Directory destination = location.childDirectory(
    tempFile.fileSystem.path.basenameWithoutExtension(tempFile.path)
    );

    destination = flutter/bin/cache/artifacts/engine/ios/artifacts which never exists.

  7. github-actions commented on Jul 31, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Jul 31, 2021
  9. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionplatform-iosiOS applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions