Skip to content

Retry chrome launch on debug connection failure #83899

New issue
New issue
Closed
#85162
Closed
Retry chrome launch on debug connection failure#83899
#85162
Assignees
jonahwilliams
Labels
P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passplatform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Description

@zanderso
zanderso
opened on Jun 3, 2021

web_tool_tests flake on setting up the debug connection with chrome:

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/2305/overview

Not sure if this is the right fix, but when hitting the exception here:

flutter/packages/flutter_tools/lib/src/web/chrome.dart

Line 392 in 59cdad4

throwToolExit(

instead of throwing a tool exit, we might try killing chrome and trying again some number of times. There's already a retry loop for spawning chrome, so maybe it just needs to be a bit wider to encompass the connection check as well?

/cc @jonahwilliams @grouma @annagrin

Activity

  1. zanderso
    added
    a: tests"flutter test", flutter_test, or one of our tests
    toolAffects the "flutter" command-line tool. See also t: labels.
    team: flakes
    platform-webWeb applications specifically
    on Jun 3, 2021

  2. jonahwilliams commented on Jun 3, 2021

    @jonahwilliams
    jonahwilliams
    on Jun 3, 2021
    Contributor

    We could definitely add one or more retries by default.

  3. jonahwilliams
    self-assigned this
    on Jun 3, 2021
  4. jonahwilliams
    added
    P2Important issues not at the top of the work list
    on Jun 8, 2021
  5. fluttergithubbot
    closed this as completedin #85162on Jun 24, 2021

  6. github-actions commented on Jul 31, 2021

    @github-actions
    github-actionsBot
    on Jul 31, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Jul 31, 2021
  8. flutter-triage-bot
    added
    c: flakeTests that sometimes, but not always, incorrectly pass
    on Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: flakeTests that sometimes, but not always, incorrectly passplatform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions