-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#4444Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine teamwaiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
It is used only here https://github.com/flutter/packages/blob/master/packages/metrics_center/lib/src/common.dart#L16, and that usage could be replaced with straightforward == and hashCode methods.
Removing the dependence would allow including fewer Dart packages in the engine DEPS file: https://github.com/flutter/engine/blob/master/DEPS#L397
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine teamwaiting for PR to land (fixed)A fix is in flightA fix is in flight