-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
All of the Dart package dependencies that the Engine needs to build are already coming in through the DEPS file, so the additional packages pulled from pub during the Engine's gclient sync are not needed. In particular, the step here:
Invokes the Dart program here through pub global activate:
However, this program exists only to generate .dart_tool/package_config.json files for the Dart programs built during the Engine build. Instead, these files could be generated by a pub get --offline so long as all of the dependencies listed in the pubspec.yaml files have "path" dependency overrides pointing at the package locations in the Engine checkout.
This will go in a few steps:
- Remove the dependency of
flutter_frontend_serveronpackage:testandpackage:mockito(to simplify further steps). - Rewrite the
pubspec.yamlfiles forconst_finderandflutter_frontend_serverto use path dependency overrides. - Rewrite run_third_party_dart.py to use
pub get --offline. - Delete dead code (
generate_package_configand the python script that calls it).
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team