-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/plugins
#4185Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: image_pickerThe Image Picker plugin.The Image Picker plugin.p: shared_preferencesPlugin to read and write Shared PreferencesPlugin to read and write Shared Preferencesp: video_playerThe Video Player pluginThe Video Player pluginplatform-webWeb applications specificallyWeb applications specifically
Description
The following plugins don't have example directories or integration tests:
- image_picker_for_web
- shared_preferences_web
- video_player_web
I'm making not having integration tests in a plugin that isn't explicitly listed as excluded when running the tests an error, to avoid repeats of the problem where we silently weren't running a bunch of our integration tests, so I'm going to list these as excluded in .cirrus.yaml for now with a reference to this issue.
If any of these genuinely shouldn't have integration tests, we could update the Cirrus script to explain why, but if there's anything we could test I would rather we have minimal tests in place (per the OKR of having a framework in place for every kind of test that could potentially be meaningful) than permanently skip them.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: image_pickerThe Image Picker plugin.The Image Picker plugin.p: shared_preferencesPlugin to read and write Shared PreferencesPlugin to read and write Shared Preferencesp: video_playerThe Video Player pluginThe Video Player pluginplatform-webWeb applications specificallyWeb applications specifically