Skip to content

Plugin PR check-list about style guide needs to reflect what the plugin repo's code style correctly #80081

@cyanglaz

Description

@cyanglaz

There's a check-list item in plugin repo asks contributors to check "I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides." (https://github.com/flutter/plugins/blame/master/.github/PULL_REQUEST_TEMPLATE.md#L11)

However, the Flutter Style Guide explicitly say the flutter repo does not use dart formatter (https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#formatting)

This caused some confusions.

We should also not remove this line, because most of the guidelines in Flutter Style Guide are still true for the plugin repo.

Maybe we should update Flutter Style Guide to state the plugin repo does use dart formatter.

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectd: wikiFlutter or engine wikispackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions