Skip to content

CircularProgressIndicator is not using ThemeData.backgroundColor by default #77647

@ghost

Description

According to the documentation [https://api.flutter.dev/flutter/material/ProgressIndicator/backgroundColor.html], a CircularProgressIndicator's backgroundColor should be the current theme's ThemeData.backgroundColor by default.

While it's the case for the valueColor (ThemeData.accentColor by default) it does not work with the backgroundColor.

I think the problem resides in the _buildMaterialIndicator method were the backgroundColor is set to widget.backgroundColor instead of _getBackgroundColor(context).

  Widget _buildMaterialIndicator(BuildContext context, double headValue, double tailValue, double offsetValue, double rotationValue) {
    return widget._buildSemanticsWrapper(
      context: context,
      child: Container(
        constraints: const BoxConstraints(
          minWidth: _kMinCircularProgressIndicatorSize,
          minHeight: _kMinCircularProgressIndicatorSize,
        ),
        child: CustomPaint(
          painter: _CircularProgressIndicatorPainter(
            backgroundColor: widget.backgroundColor,
            valueColor: widget._getValueColor(context),
            value: widget.value, // may be null
            headValue: headValue, // remaining arguments are ignored if widget.value is not null
            tailValue: tailValue,
            offsetValue: offsetValue,
            rotationValue: rotationValue,
            strokeWidth: widget.strokeWidth,
          ),
        ),
      ),
    );
  }

Metadata

Metadata

Assignees

Labels

f: material designflutter/packages/flutter/material repository.found in release: 2.0Found to occur in 2.0found in release: 2.1Found to occur in 2.1frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work on

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions