-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: desktopRunning on desktopRunning on desktopplatform-linuxBuilding on or for Linux specificallyBuilding on or for Linux specificallyteam-linuxOwned by the Linux platform teamOwned by the Linux platform teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-linuxTriaged by the Linux platform teamTriaged by the Linux platform team
Description
I vaguely remember having a conversation with @stuartmorgan about why this file isn't in the ephemeral directory but I can't recall the details.
Either it should be generated in the ephemeral directory so it's not checked into source control, or if it is supposed to be checked into source control, all the generated_plugin_registrant files checked in the Flutter repo should be updated to have // clang-format off so we don't get a dirty working copy every time we build an example or integration test app.
#76662
diff --git a/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc b/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc
index 026851fa2f..f6f23bfe97 100644
--- a/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc
+++ b/dev/integration_tests/flutter_gallery/linux/flutter/generated_plugin_registrant.cc
@@ -2,6 +2,8 @@
// Generated file. Do not edit.
//
+// clang-format off
+
#include "generated_plugin_registrant.h"
#include <url_launcher_linux/url_launcher_plugin.h>
Merrit and lishaduck
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: desktopRunning on desktopRunning on desktopplatform-linuxBuilding on or for Linux specificallyBuilding on or for Linux specificallyteam-linuxOwned by the Linux platform teamOwned by the Linux platform teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-linuxTriaged by the Linux platform teamTriaged by the Linux platform team