Skip to content

Failing tests running in devicelab_staging, not blocking tree #74431

Closed

Description

@christopherfujino

"Mac_android hot_mode_dev_cycle__benchmark" is currently failing in devicelab_staging. It is not running in either cocoon or luci devicelab prod (and thus not blocking the tree) https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20hot_mode_dev_cycle__benchmark/36/overview

Brief summary of what happened:

  • due to a mistake during the cocoon -> luci devicelab migration, 100% of the mac/android bots were moved from cocoon to devicelab_staging, and thus the cocoon builds were not running and thus failing tests did not make the tree red.
  • there were three failing tests that were not noticed by the framework gardener. the three tests were Mac_android microbenchmarks, Mac_android hot_mode_dev_cycle__benchmark and Mac_android android_semantics_integration_test.
  • 444c954 was landed to intentionally fail hot_mode_dev_cycle_macos_targetbenchmark in order to explicitly close the tree until either the tests are fixed or the devicelab tests are migrated to devicelab prod, in which case they will show up on the build dashboard.
  • 75dc45a was landed to fix Mac_android hot_mode_dev_cycle__benchmark
  • The revert cecb7f3 was landed to fix Mac_android android_semantics_integration_test (the initial commit landed right after the migration of the test from cocoon to devicelab_staging)
  • the mac/android tests have been migrated to devicelab prod luci group.
  • 3c27a56 landed to add the LUCI mac/android tasks to the build dashboard.

Things that need to happen for this issue to be closed:

  • Mac_android hot_mode_dev_cycle__benchmark passes green build
  • Mac_android android_semantics_integration_test fixed and passes green build
  • Mac_android microbenchmarks passes green build
  • framework prod_builders.json file updated to include mac/android tasks PR
  • the intentional fail in hot_mode_dev_cycle_macos_targetbenchmark removed PR

Activity

  1. added
    P0Critical issues such as a build break or regression
    on Jan 21, 2021
  2. christopherfujino commented on Jan 21, 2021

    @christopherfujino
    ContributorAuthor
  3. changed the title [-]"Mac_android hot_mode_dev_cycle__benchmark" failing[/-] [+]Failing tests running in devicelab_staging, not blocking tree[/+] on Jan 21, 2021
  4. jonahwilliams commented on Jan 21, 2021

    @jonahwilliams
    Contributor
  5. godofredoc commented on Jan 21, 2021

    @godofredoc
    Contributor

    Mac android were moved to prod and they will become blockers in a few mins

  6. added and removed
    P0Critical issues such as a build break or regression
    on Jan 21, 2021
  7. godofredoc commented on Jan 21, 2021

    @godofredoc
    Contributor

    Moving to P1

  8. github-actions commented on Aug 6, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Aug 6, 2021
  10. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P0Critical issues such as a build break or regressionc: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions