-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listbrowser: safari-macosonly manifests in Safari on macOSonly manifests in Safari on macOSc: crashStack traces logged to the consoleStack traces logged to the consolee: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for WebCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Webengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specifically
Description
On LUCI Safari sometimes reports a fatal error. Example:
00:29 �[32m+587�[0m�[33m ~23�[0m�[31m -1�[0m: test/canvaskit/embedded_views_test.dart: HtmlViewEmbedder renders overlays on top of platform views �[1m�[31m[E]�[0m�[0m
Error: Unreachable code should not be executed (evaluating 'invoker(fn, thisWired)')
../src/engine/canvaskit/surface.dart 272:5 flush
../src/engine/canvaskit/surface.dart 248:5 _presentSurface
../src/engine/canvaskit/surface.dart 91:14 call
../src/engine/canvaskit/surface.dart 26:12 submit
../src/engine/canvaskit/embedded_views.dart 351:7 submitFrame
../src/engine/canvaskit/rasterizer.dart 37:15 draw
embedded_views_test.dart 285:9 <fn>
The issue seems to be related to Safari bug https://bugs.webkit.org/show_bug.cgi?id=169722. According to a comment it might have been fixed. It is unclear if the fix will ever be backported to pre-14 Safari versions.
One solution might be to upgrade our mac bots to Safari 14, which will likely require upgrade to a newer version of macOS altogether (unless we use Safari Technology Preview instead of the system-installed one).
Aravinthan-Subramanian
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listbrowser: safari-macosonly manifests in Safari on macOSonly manifests in Safari on macOSc: crashStack traces logged to the consoleStack traces logged to the consolee: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for WebCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Webengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specifically