-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-fuchsiaFuchsia code specificallyFuchsia code specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Use case
zircon.System in flutter engine defines a clockGet function that uses the Fuchsia zx_clock_get syscall and the associated concept of a clock ID.
Per RFC-0008 this syscall and the concept of a clock ID are deprecated in Fuchsia and I'm working through the long process of removing dependencies, including Flutter.
Proposal
Thankfully this function is not heavily used and all the invocations I can find are for monotonic time. Therefore, as documented in fxbug.dev/66266 I'm recommending the following:
- Add a new
clockGetMonotonicoperation inzircon.System. - Wait for that to roll into fuchsia and other repos
- Move all the call sites from
zircon.System.clockGet(_zxClockMonotonic)tozircon.System.clockGetMonotonic() - Mark the
clockGetfunction deprecated upstream (and maybe have it return an exception instead of attempting the syscall so we unblock the removal of the syscall?) - Wait some more
- Remove
zircon.System.clockGetentirely
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-fuchsiaFuchsia code specificallyFuchsia code specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team