Skip to content

Linter: Undefined symbol GrDirectContext::MakeVulkan #68331

New issue
New issue
Open
flutter/engine
#21927
Open
Linter: Undefined symbol GrDirectContext::MakeVulkan#68331
flutter/engine
#21927
Labels
P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.from: sanitizerIssues caught by engine sanitizers. May be false positives.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team
@cbracken

Description

@cbracken
cbracken
opened on Oct 16, 2020

In flutter/vulkan/vulkan_window.cc, the call to GrDirectContext::MakeVulkan is undefined when SK_VULKAN is not defined.

If clang-tidy supports runs with a -D or similar mechanism for symbols, we could try running with that defined. Otherwise, we should disable linting immediately at the call site, for that line only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.from: sanitizerIssues caught by engine sanitizers. May be false positives.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions