-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.from: sanitizerIssues caught by engine sanitizers. May be false positives.Issues caught by engine sanitizers. May be false positives.
Description
Because we tend to tack // FLUTTER_NOLINT lines onto the first available line after the copyright header, and because we tend to copy existing copyright headers into newly-created files, there are very good chances that the linter opt-out comment ends up accidentally copied along with the header.
Further, it's often unclear why a given file is opted out of the linter. We should update ci/bin/lint.dart to verify that when a FLUTTER_NOLINT comment is found, it is followed by a GitHub issue URL, or we fail the lint for the file.
Metadata
Metadata
Assignees
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.from: sanitizerIssues caught by engine sanitizers. May be false positives.Issues caught by engine sanitizers. May be false positives.