-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/plugins
#3113Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsp: connectivityThe connectivity pluginThe connectivity pluginp: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginp: shared_preferencesPlugin to read and write Shared PreferencesPlugin to read and write Shared Preferencesp: url_launcherPlugin to launch external applicationsPlugin to launch external applicationsp: video_playerThe Video Player pluginThe Video Player pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Milestone
Description
Steps to Reproduce
After an unrelated push (this is probably related to an update in the flutter version used by the plugins repo, and not the latest changes), tests in flutter/plugins repo for the following plugins:
- connectivity/connectivity
- google_sign_in/google_sign_in
- shared_preferences/shared_preferences
- url_launcher/url_launcher
- video_player/video_player
are failing to compile with some null-safety related errors:
test/video_player_test.dart:27:7: Error: Field 'textureId' should be initialized because its type 'int' doesn't
allow null.
int textureId;
^^^^^^^^^
To reproduce:
- Ensure you're in the latest flutter from master, with the latest dart sdk.
- Enter the directory of one of the affected plugins
- Run
flutter clean && flutter test --platform=chrome
Expected results:
Deleting .dart_tool... 26ms
Running "flutter pub get" in video_player... 0.3s
00:13 +39 ~1: All tests passed!
Actual results:
The errors above.
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsp: connectivityThe connectivity pluginThe connectivity pluginp: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginp: shared_preferencesPlugin to read and write Shared PreferencesPlugin to read and write Shared Preferencesp: url_launcherPlugin to launch external applicationsPlugin to launch external applicationsp: video_playerThe Video Player pluginThe Video Player pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.