Skip to content

Engine roller blocked due to switch statements enforcing non-null enums #66674

Closed

Description

@jason-simmons

A recent change to the Dart SDK will throw an exception if a null value is passed to an exhaustive switch statement on a non-nullable enum type.
(see dart-lang/sdk@2414b29)

This is causing failures in some tests. In particular, tests that pass a mock HttpResponse to consolidateHttpClientResponseBytes will now need to populate the compressionState field.

Activity

  1. added
    P0Critical issues such as a build break or regression
    on Sep 25, 2020
  2. added
    a: tests"flutter test", flutter_test, or one of our tests
    on Sep 25, 2020
  3. zanderso commented on Sep 25, 2020

    @zanderso
    Member
  4. zanderso commented on Sep 28, 2020

    @zanderso
    Member

    The roll is now failing on #66829

  5. github-actions commented on Aug 12, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressiona: tests"flutter test", flutter_test, or one of our testsdependency: dartDart team may need to help us

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions