Skip to content

Engine linting fails on existing files #64576

@stuartmorgan-g

Description

@stuartmorgan-g

The linter was recently turned on (#61875), and it seems to be running on entire files, any time those files are touched. See for example this failure, which is on a line that the PR doesn't touch. Having these linter 'land mines' in files adds friction to PRs, and encourages mixing of linter fixes with functional changes.

Can we either run the linter only on changed lines (not sure if that's possible) or not enable the linter where the codebase isn't already clean?

@gaaclarke

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions