-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
There has been interest in adding desktop support to device_info (see #39674, flutter/plugins#2942 (comment)); it's not really clear to me how we would evaluate whether to accept or reject any given information being added there; there are obvious easy things (e.g., exact OS version), and all kinds of things that obviously wouldn't belong, but a huge grey area that could arguably be "device" information, but would potentially be too niche. I think we should more clearly articulate the intended scope of device_info somewhere in the README or docs.
It would also be nice to take a step back as we extend it to new platforms and consider extracting a base class for the info structure. There are many reasonable things that could be included that would be common across at least all of desktop, and maybe all devices, and having a few common abstractions for those things would be good.