-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/plugins
#2934Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: null-safetySupport for Dart's null safety featureSupport for Dart's null safety featurecustomer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.Relating to flutter/gallery repository. Please transfer non-framework issues there.platform-webWeb applications specificallyWeb applications specifically
Description
We need to do breaking change releases for package:process/platform/file in order to migrate flutter_goldens and flutter_goldens_client. However, we have a dependency on the gallery in the macro-benchmarks. This transitively depends on a lower version of platform.
Because every version of gallery from git depends on google_fonts ^1.0.0 which depends on path_provider ^1.4.0, every version of gallery from git requires path_provider ^1.4.0.
And because path_provider >=1.2.2 <1.6.4 depends on platform ^2.0.0, every version of gallery from git requires platform ^2.0.0 or path_provider ^1.6.4.
And because path_provider >=1.6.4 depends on path_provider_platform_interface ^1.0.1 which depends on platform ^2.0.0, every version of gallery from git requires platform ^2.0.0.
So, because flutter_update_packages depends on both platform 3.0.0-nullsafety.1 and gallery from git, version solving failed.
Running "flutter pub upgrade" in flutter_update_packages.mTtFaI...
pub upgrade failed (1; So, because flutter_update_packages depends on both platform 3.0.0-nullsafety.1 and gallery from git, version solving failed.)
We should not re-publish platform as a non-breaking version constraint, since the update to null-safety required a breaking change in the FakePlatform class.
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: null-safetySupport for Dart's null safety featureSupport for Dart's null safety featurecustomer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.Relating to flutter/gallery repository. Please transfer non-framework issues there.platform-webWeb applications specificallyWeb applications specifically