Skip to content

Enable/disable luci tests in a single file per repository #63437

Closed

Description

@keyonghan

As we are migrating tests to luci for all repos, a single file to control tests is needed, similar to the yaml file for cirrus tests (flutter): https://github.com/flutter/flutter/blob/master/.cirrus.yml

On builder level, we will use try_builders.json in different repos by adding an enabled flag.

  • add flag to engine
  • add flag to framework
  • add flag to cocoon
  • add flag to packages
  • updating cocoon backend to include enable/disable logic

Activity

  1. self-assigned this
    on Aug 10, 2020
  2. keyonghan commented on Aug 11, 2020

    @keyonghan
    ContributorAuthor

    @godofredoc Please correct me if anything is incorrect.

    I guess what needs here is to enable/disable luci tasks in sub-shard level similar to cirrus yaml file.

    (on shard level, https://github.com/flutter/flutter/blob/master/dev/try_builders.json would be the source control to enable/disable a builder)

    Sub-shards are configured in flutter/infra, but we want to control on repo level. With those manifest files ready in corresponding repos, cocoon will read those manifest before triggering pre-submit tasks. The subshards value derived from the manifest file will be added to https://github.com/flutter/cocoon/blob/master/app_dart/lib/src/service/luci_build_service.dart#L193 to replace server side configuration.

  3. godofredoc commented on Aug 11, 2020

    @godofredoc
    Contributor

    I was thinking on expanding the json file with an enabled flag. Something similar to the flaky flag but we will also need a way to disable tests from shards.

  4. keyonghan commented on Aug 12, 2020

    @keyonghan
    ContributorAuthor

    I was thinking on expanding the json file with an enabled flag. Something similar to the flaky flag but we will also need a way to disable tests from shards.

    Thanks. A flag is good to keep the historical builders all the time.
    I will start from the builder level. Then move on to the shard level.

  5. github-actions commented on Aug 13, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listteam-infraOwned by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions