Skip to content

Remove // ignore: unnecessary_null_comparison when null safety is on by default #59207

@yjbanov

Description

@yjbanov

flutter/engine#18933 added temporary // ignore: unnecessary_null_comparison in places where we check non-nullable variables for null. These are there because temporarily Flutter will still run with null safety off by default, and so the asserts are the only way to validate non-nullness. When we flip that mode, however, we should clean up asserts along with // ignore: unnecessary_null_comparison.

/cc @jonahwilliams

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: null-safetySupport for Dart's null safety featurec: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions