Skip to content

[pigeon] make sure the generated code is free of analyzer warnings #59116

Closed
flutter/packages
#3317

Description

@xster

Since the user checks in the generated code, it could show up in their own code analysis.

Screen Shot 2020-06-09 at 5 50 51 PM

Activity

  1. changed the title [-][[/-] [+][pigeon] make sure the generated code is free of analyzer warnings[/+] on Jun 10, 2020
  2. added
    packageflutter/packages repository. See also p: labels.
    p: pigeonrelated to pigeon messaging codegen tool
    on Jun 10, 2020
  3. xster commented on Apr 15, 2021

    @xster
    ContributorAuthor

    @GaryQian can you check this out too? It might already be solved though since Aaron added linter checks to the tests for Java.

  4. added
    P2Important issues not at the top of the work list
    on Oct 12, 2021
  5. removed their assignment
    on Aug 9, 2022
  6. GaryQian commented on Aug 9, 2022

    @GaryQian
    Contributor

    @gaaclarke Is this still a problem with Pigeon?

  7. gaaclarke commented on Aug 9, 2022

    @gaaclarke
    Member

    @gaaclarke Is this still a problem with Pigeon?

    There are probably still analyzer warnings. There has been some steps that make this not as big of a deal. Internally the code is generated, not checked in and we've added "generated" annotations which causes them to be treated different.

  8. stuartmorgan-g commented on Jan 4, 2023

    @stuartmorgan-g
    Contributor

    We should turn on warnings-as-errors in the integration test host plugin for all languages, which would cover most of this.

  9. github-actions commented on Mar 14, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P2Important issues not at the top of the work listp: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions