Skip to content

--trace-skia not getting sent to the engine for iOS simulator #52676

@gaaclarke

Description

@gaaclarke

Flutter version: bbc5b9d

If I run flutter with: flutter run --trace-skia

On an engine that has the following patch:

--- a/shell/common/switches.cc
+++ b/shell/common/switches.cc
@@ -271,9 +271,11 @@ Settings SettingsFromCommandLine(const fml::CommandLine& command_line) {
 
   settings.trace_skia =
       command_line.HasOption(FlagForSwitch(Switch::TraceSkia));
+  FML_LOG(ERROR) << "trace skia:" << settings.trace_skia;
 
   command_line.GetOptionValue(FlagForSwitch(Switch::TraceWhitelist),
                               &settings.trace_whitelist);

It prints out: [VERBOSE-2:switches.cc(274)] trace skia:0

I supplied the flag --observatory-port 123 and that does get passed through.

Seen on: iOS

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.platform-iosiOS applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions