Repository navigation
Diagnosticable should be made into a mixin #50498
Description
Since Diagnosticable and classes that implement DiagnosticableMixin aren't the same type, code can't compare the type of an object with Diagnosticable to find out if it should call toDiagnosticsNode or not. See #49647 for more details.
In #49726, I fixed all the instances of this in Flutter where this happens by adding implements Diagnosticable to all of the mixin classes, but I still need to fix some instances of it in Google internal code before removing Diagnosticable entirely in favor of DiagnosticableMixin
Activity
[-]Diagnosticable should be remove in favor of DiagnosticableMixin[/-][+]Diagnosticable should be removed in favor of DiagnosticableMixin[/+][-]Diagnosticable should be removed in favor of DiagnosticableMixin[/-][+]Diagnosticable should be made into a mixin[/+]gspencergoog commentedon Feb 26, 2020
The plan now is to remove
DiagnosticableMixineventually, and just keep the mixinDiagnosticable, effectively converting the abstract classDiagnosticableinto a mixin.DiagnosticableMixincan't be removed until the mixin version ofDiagnosticableis available in the stable branch, since some plugins that currently useDiagnosticableMixinwant to be compatible with both stable and master.Hixie commentedon May 31, 2020
I believe this has now been in a stable release.
gspencergoog commentedon May 31, 2020
Yes, this is already on my list to do.
Use Diagnosticable instead of DiagnosticableMixin (#166)
github-actions commentedon Aug 19, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.