-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#16105Labels
a: desktopRunning on desktopRunning on desktope: embedderUsers of the Embedder APIUsers of the Embedder APIengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically
Description
After testing a bunch of C method, I found out there is something strange in the flutter engine source code
std::string icu_data_path;
if (SAFE_ACCESS(args, icu_data_path, nullptr) != nullptr) {
icu_data_path = SAFE_ACCESS(args, icu_data_path, nullptr);
}
...
settings.icu_data_path = icu_data_path;
settings.assets_path = args->assets_path;
According to icu_data_path, why does assets_pathnot need to use SAFE_ACCESS? This is the wired thing I found, becuase icu_data_path seems to work with Chinese, but assets_path not.
I think the code for assets_path should be the same as icu_data_path:
std::string assets_path ;
if (SAFE_ACCESS(args, assets_path , nullptr) != nullptr) {
assets_path = SAFE_ACCESS(args, assets_path , nullptr);
}
...
settings.assets_path = assets_path ;
I can't pretty sure this is the error, but after testing every single function with legal Chinese path, this is the only possibility different code. If this is not a legal issue, feel free to close 😢
Metadata
Metadata
Assignees
Labels
a: desktopRunning on desktopRunning on desktope: embedderUsers of the Embedder APIUsers of the Embedder APIengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically