-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
a: existing-appsIntegration with existing apps via the add-to-app flowIntegration with existing apps via the add-to-app flowp: firebaseFirebase pluginsFirebase pluginspackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specifically
Milestone
Description
The v2 embedding plugins added support for v1.9, but v1.12 adds a few fixes that help the v2 path significantly. We should migrate the plugins to use v1.12 now that it's the most recent stable.
For each plugin, we should:
- Change the minimum supported Flutter version in the
pubspec.yamlto^v1.12.13+hotfix.5. - (Optional) Remove any constraint in the example's pubspec.yaml, if it exists.
- Remove the
afterEvaluateblock hacking in inclusion of the lifecycle library. - Add the embedding v2 metadata xml tag. Otherwise, we're not autogenerating the v2 plugin registration. But since the tool can only autogenerate for one version of the embedding (even if it can toggle between v1 and v2 plugin APIs against the v2 embedding), we'd have to manually register the plugin in the EmbedderV1Activity.java.
- Change to the getBinaryMessenger getter since getFlutterEngine.getDartExecutor is deprecated.
- (Optional) we can remove the MainActivity for the v2 embedding in the example now since it has no content.
- Bump the plugin version
These look like the plugins that need to be updated:
- android_alarm_manager
- android_intent ([android_intent] Bump to Flutter stable, remove deprecation warnings plugins#2586)
- battery ([battery] cleanup for Android embedding post 1.12 plugins#2400)
- camera
- connectivity ([connectivity, battery, android_alarm_manager] v2 support plugins#2613)
- device_info ([device_info] Update Android embedding to match latest Flutter stable release plugins#2590)
- e2e
- firebase_admob
- firebase_analytics
- firebase_auth
- firebase_core
- firebase_crashlytics
- firebase_database
- firebase_dynamic_links
- firebase_in_app_messaging
- firebase_messaging
- firebase_ml_vision
- firebase_performance
- firebase_remote_config
- firebase_storage
- flutter_plugin_android_lifecycle
- google_sign_in
- in_app_purchase
- local_auth
- package_info ([package_info] Upgrade to 1.12 Flutter and cleanup. plugins#2603)
- path_provider
- quick_actions ([quick_actions] Upgrade to 1.12 Flutter and cleanup. plugins#2605)
- sensors
- share
- shared_preferences
- url_launcher
- video_player
- webview_flutter ([flutter_webview] Raise min Flutter SDK to stable plugins#2425)
ETA: The current state of these plugins also print out deprecation warnings at build time because they access getEngine() directly.
alexandergottlieb, dkobia, MickaelHrndz, mayurdhurpate, masewo and 10 more
Metadata
Metadata
Labels
a: existing-appsIntegration with existing apps via the add-to-app flowIntegration with existing apps via the add-to-app flowp: firebaseFirebase pluginsFirebase pluginspackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specifically