Skip to content

[web][tests] Fix skipped firefox unit tests #46638

@nturgut

Description

@nturgut

flutter web engine unit tests will be running on firefox (as an addition to chrome) with PR: flutter/engine#14267

The following tests are not skipped on Firefox since they were failing:

test/paragraph_test.dart: predictably lays out a multi-line rich paragraph (canvas measurement)
test/paragraph_test.dart: predictably lays out a single-line rich paragraph
test/paragraph_test.dart: predictably lays out a multi-line rich paragraph
test/paragraph_test.dart: predictably lays out a single-line rich paragraph (canvas measurement)
test/engine/semantics/semantics_helper_test.dart: MobileSemanticsEnabler Not relevant events should be forwarded to the framework
test/dom_renderer_test.dart: replaces viewport meta tags during style reset
test/text/font_collection_test.dart: FontManager Register Asset twice with special character slash
test/text/font_collection_test.dart: FontManager Register Asset twice with exclamation mark
test/text/font_collection_test.dart: FontManager Register Asset twice with coma
test/text/font_collection_test.dart: FontManager Register Asset twice with a digit at the start of a token
test/text_test.dart: should not set fontFamily to effectiveFontFamily for spans in rich text
test/text_test.dart: adds Arial and sans-serif as fallback fonts
test/text_editing_test.dart: TextEditingElement Can read editing state correctly
test/text_editing_test.dart: TextEditingElement Re-acquires focus
test/text_editing_test.dart: TextEditingElement Multi-line mode also works
test/text_editing_test.dart: HybridTextEditing Syncs the editing state back to Flutter
test/text_editing_test.dart: HybridTextEditing Multi-line mode also works
test/compositing_test.dart: parent child lifecycle build, retain, update, and applyPaint are called the right number of times
test/compositing_test.dart: parent child lifecycle build, retain, update, and applyPaint are called the right number of times

We should either:
(1) fix the code to run on firefox
(2) add unit tests methods that cover the firefox case (These might all be the locations in the code we are using BrowserEngine.Firefox check)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsbrowser: firefoxonly manifests in Firefoxengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions