-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
The Flutter Gold dashboard does not currently support notifications.
This is a sticking point in the case where:
- Pull request 1 lands, changing pre-existing golden file A
- Triage is not completed to approve the change
- The change ignore expires
- Pull request 2 picks up change to golden file A from master
- Pre-submit checks for PR 2 fail since there is no approved match for updated golden file A
This is not an often occurring case, as golden files are not changed often (they are visual constants!), and triage breakdown is also uncommon with considerate ignore practice.
To address this case, I would like to implement a notification system, likely through flutter/cocoon, that will ping PRs or directly email ignore owners before they expire, closing the potential gap for triage breakdown. This notification would encourage the owner to either
- triage images (if change has landed)
- extend ignore (if change has not landed)
- delete ignore (if triage has been completed, or if the change is not actually ready to land)
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight