-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: existing-appsIntegration with existing apps via the add-to-app flowIntegration with existing apps via the add-to-app flowc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specifically
Description
Right now we're manually doing this in all of our V2 activities in the example apps:
@Override
public void configureFlutterEngine(FlutterEngine flutterEngine) {
flutterEngine.getPlugins().add(new PluginName());
}That's something we don't want to really show as an actual example or tell people to do, because GeneratedPluginRegistrant should ideally automatically call getPlugins().add itself for users.
Currently on stable GeneratedPluginRegistrant always uses the old embedding. There's a PR that's about to land on master that will change it to use the new embedding when it's available, #42684.
Once #42684 lands and rolls to stable the migrated plugins should change their example apps to rely on the Registrant instead of manually adding anything in their activity.
hpoul, dmiedev and caio-lc-coelho
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: existing-appsIntegration with existing apps via the add-to-app flowIntegration with existing apps via the add-to-app flowc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specifically