You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Document the structs in the embedder API that are sealed. #38470
This can be done via comments in the header. Most structs are safe to modify by appending members at the end of the struct. However, some are not (these are the ones without struct_size or the ones that are non-pointer union members in other structs.)
We could also unit-test them for added assurance (e.g., have a test that asserts that the address of the first member plus the size of the struct is the same as the address of the expected last member plus the size of that member).
We could also unit-test them for added assurance (e.g., have a test that asserts that the address of the first member plus the size of the struct is the same as the address of the expected last member plus the size of that member).
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
stuartmorgan-g commentedon Aug 13, 2019
We could also unit-test them for added assurance (e.g., have a test that asserts that the address of the first member plus the size of the struct is the same as the address of the expected last member plus the size of that member).
loic-sharma commentedon Apr 20, 2026
This bit was added by:
I'll leave this open as we should do a pass to verify all sealed structs are documented.
Document frozen embedder API structs (flutter#186842)
loic-sharma commentedon Oct 16, 2026
Done by #186842
github-actions commentedon Oct 30, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.