Repository navigation
flutter/packages Palatte can not work #36456
Description
void imageListener(ImageInfo info, bool synchronousCall) {
loadFailureTimeout?.cancel();
stream.removeListener(imageListener);
imageCompleter.complete(info.image);
}
if (timeout != Duration.zero) {
loadFailureTimeout = Timer(timeout, () {
stream.removeListener(imageListener);
imageCompleter.completeError(
TimeoutException(
'Timeout occurred trying to load from $imageProvider'),
);
});
}
stream.addListener(imageListener);
Those code can not work with newest flutter, how to change it?
Activity
stuartmorgan-g commentedon Jul 18, 2019
@tvolkert This is from https://groups.google.com/forum/#!topic/flutter-announce/NWTszrEq9U0
Is there a standard process for updating first-party packages for breaking changes?
lucasjinreal commentedon Jul 19, 2019
@stuartmorgan I think the changes of new api has been made far way, the best way is to update old packages.
Those code is from flutter/packages palatte_genereator, Does it maintained by flutter team? Why not update it's down usage anyway?
That is a good package help us get domain color from a single image even a networkimage widget.
Or, if any instructions how to edit those
error warning codeis also ok, I can change it myself...stuartmorgan-g commentedon Jul 19, 2019
That's exactly what my comment was suggesting.
tvolkert commentedon Jul 19, 2019
Right now there's no standard way. Ian has just set up in the past week a way to run non-framework tests as part of framework commits, so we should wire up packages and plugin tests into that system so we get alerted to such breakages.
In the meantime, this should just be updated by a willing soul, and since I don't like volunteering other people, I guess that willing soul is me 🙂
tvolkert commentedon Jul 19, 2019
Fixed in flutter/packages#24
lucasjinreal commentedon Jul 19, 2019
@tvolkert Seems willing soul has been resolved this issue, thanks so much! I will update that package!
tvolkert commentedon Jul 19, 2019
I haven't merged the fix yet or published a new version, so re-opening.
lucasjinreal commentedon Jul 19, 2019
@tvolkert Thanks tvolkert! Hope you can release it soon!
zoeyfan commentedon Jan 3, 2020
Looking at the status of flutter/packages#24, may I assume this has been fixed now, therefore can be closed?
github-actions commentedon Aug 24, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.