Skip to content

Driver tests should fail when method channel calls are failed. #33863

@amirh

Description

@amirh

The MethodChannel code swallows exceptions and logs them to an error here:

https://github.com/flutter/engine/blob/661c24e4f359c60915a21c285d1d34777f0ccb30/shell/platform/android/io/flutter/plugin/common/MethodChannel.java#L205

This resulted in a recent regression(fixed in flutter/engine#9185 going unnoticed for over a day, even that we had a driver test triggering the bad code(as the exception was just logged).

We should make sure tests are failing when this happen(same for IncomingMethodCallHandler#onMessage).

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: platform-viewsEmbedding Android/iOS views in Flutter appsengineflutter/engine related. See also e: labels.platform-androidAndroid applications specificallyt: flutter driver"flutter driver", flutter_drive, or a driver testteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions