-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Breaking changes in the framework sometimes break plugins code.
As the flutter/plugins plugins are running against master on CI, but are required to also work on latest stable it often makes it challenging to "fix" the issue in the plugins repository. 2 recent examples:
- Add template type parameter to
invokeMethodcalls in the plugins repo #26431 - Revive the "set marker icon" sample for Google Maps #33438
I suggest that we block landing framework PRs that are breaking the plugins repository. While seemingly this might leave the author with a chicken-and-egg problem(how can they update the plugin code to adapt to the breaking change before the framework change has landed), but not blocking landing the change just moves the issue downstream(we can't update the plugin code before the breaking change made it to stable).
So we should solve this chicken-and-egg issue early on when there's still the option to re-plan the landing process(e.g land the change in 2 phases, the second phase lands only after the first phase made it to stable).