-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/f: cupertinoflutter/packages/flutter/cupertino repositoryflutter/packages/flutter/cupertino repositoryframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
CupertinoDialogAction.isDefaultAction is a misleading name for iOS developers.
On iOS UIAlertAction.Style is an enum with 3 cases:
case `default`
case cancel
case destructiveCupertinoDialogAction's constructor's signature:
const CupertinoDialogAction({
VoidCallback onPressed,
bool isDefaultAction: false,
bool isDestructiveAction: false,
TextStyle textStyle,
@required Widget child
})where isDefaultAction is easily mistakable for the default case but they do different things and are not mutually exclusive.
Should probably explicitly state in the documentation that isDefaultAction is not the same as UIAlertAction.Style.default
Version
Channel master, v1.5.9-pre.117
Metadata
Metadata
Assignees
Labels
d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/f: cupertinoflutter/packages/flutter/cupertino repositoryflutter/packages/flutter/cupertino repositoryframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.