Skip to content

"flutter upgrade" on a clean install is way too noisy and doing sketchy things #31702

@Hixie

Description

@Hixie

I downloaded the beta / v1.4.9-hotfix.1 archive.

ianh@ianh:~/dev/test-install/flutter$ bin/flutter --version
Flutter 1.4.9-hotfix.1 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 88fa7ea403 (2 weeks ago) • 2019-04-11 14:01:46 -0700
Engine • revision 4737fc5cd8
Tools • Dart 2.2.1 (build 2.2.1-dev.4.0 None)

At this time, it's the latest beta. I ran flutter upgrade:

ianh@ianh:~/dev/test-install/flutter$ bin/flutter upgrade
Upgrading Flutter from /usr/local/google/home/ianh/dev/test-install/flutter...
From https://github.com/flutter/flutter
   2427163d5..d1b146355  Hixie-patch-2 -> origin/Hixie-patch-2
   6c7b6833c..0ba67226e  dev           -> origin/dev
   6c7b6833c..c15d48e29  master        -> origin/master
   e9dd13d1a..5ae6952c0  revert-30873-revert-30414-remove-hover-pressure -> origin/revert-30873-revert-30414-remove-hover-pressure
 * [new branch]          revert-30951-roll_branch -> origin/revert-30951-roll_branch
 * [new branch]          revert-30991-caretheight -> origin/revert-30991-caretheight
 * [new branch]          revert-30995-revert_engine -> origin/revert-30995-revert_engine
 * [new tag]             v1.5.8        -> v1.5.8
 * [new tag]             v1.5.0        -> v1.5.0
 * [new tag]             v1.5.1        -> v1.5.1
 * [new tag]             v1.5.2        -> v1.5.2
 * [new tag]             v1.5.3        -> v1.5.3
 * [new tag]             v1.5.4        -> v1.5.4
 * [new tag]             v1.5.5        -> v1.5.5
 * [new tag]             v1.5.6        -> v1.5.6
 * [new tag]             v1.5.7        -> v1.5.7
Updating 16a16e659..88fa7ea40
 1 file changed, 1 insertion(+), 1 deletion(-)

Upgrading engine...
Building flutter tool...

Flutter 1.4.9-hotfix.1 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 88fa7ea403 (2 weeks ago) • 2019-04-11 14:01:46 -0700
Engine • revision 4737fc5cd8
Tools • Dart 2.2.1 (build 2.2.1-dev.4.0 None)

Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.4.9-hotfix.1, on Linux, locale en_US.UTF-8)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[!] Android Studio (version 2.3)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] IntelliJ IDEA Community Edition (version 2017.3)
[!] Connected device
    ! No devices available

! Doctor found issues in 3 categories.

There's all manner of problems here.

  • Why did the tool rebuild?
  • What does Updating 16a16e659..88fa7ea40 mean? (git stash output, I expect)
  • What does 1 file changed, 1 insertion(+), 1 deletion(-) mean? (git stash output, I expect, but this should be a clean install with no changes)
  • We really should consider silencing the git fetch call.
  • It tells me it's Upgrading engine but actually it didn't do anything.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: first hourThe first hour of using Flutterteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions