Hero animation changes scroll offset of ListView after navigator.pop #31503
Description
Steps to Reproduce
In the example app below we have 2 screens. The first one has a list view with multiple images and each image is has a Hero widget as an ancestor with a unique ID. If we scroll to the bottom of the list and tap on the image, we open the second screen that has the same widget (Hero with image). The issue happens when we pop the route and return to the first screen: the scroll offset is not the same as when we tapped on the card.
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) => MaterialApp(
home: FirstScreen(),
);
}
class FirstScreen extends StatelessWidget {
FirstScreen({Key key}) : super(key: key);
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: ListView(
children: List<Widget>.generate(
10,
(index) => GestureDetector(
onTap: () => Navigator.of(context).push(MaterialPageRoute<void>(
builder: (BuildContext context) => SecondScreen(
Hero(
tag: index,
child: ImageWithLabel(index),
),
))),
child: Hero(
tag: index,
child: ImageWithLabel(index),
),
),
),
),
),
);
}
}
class SecondScreen extends StatelessWidget {
const SecondScreen(this.child);
final Widget child;
@override
Widget build(BuildContext context) => Scaffold(
appBar: AppBar(),
body: Center(child: child),
);
}
class ImageWithLabel extends StatelessWidget {
const ImageWithLabel(this.index);
final int index;
@override
Widget build(BuildContext context) => Padding(
padding: const EdgeInsets.symmetric(vertical: 4),
child: Material(
color: Colors.transparent,
child: Stack(
alignment: Alignment.center,
children: <Widget>[
Image.network('https://picsum.photos/250?image=9'),
Text(index.toString(), style: TextStyle(color: Colors.white, fontSize: 20, fontWeight: FontWeight.bold)),
],
),
),
);
}Logs
[✓] Flutter (Channel unknown, v1.4.18, on Mac OS X 10.14.4 18E226, locale en-NL)
• Flutter version 1.4.18 at /Users/user/IdeaProjects/project/flutter
• Framework revision 8bea3fb2eb (12 days ago), 2019-04-11 13:11:22 -0700
• Engine revision 72986c39ea
• Dart version 2.2.1 (build 2.2.1-dev.3.1 None)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/user/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
• All Android licenses accepted.
[!] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.2.1, Build version 10E1001
✗ Verify that all connected devices have been paired with this computer in Xcode.
If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
To update with Brew, run:
brew update
brew uninstall --ignore-dependencies libimobiledevice
brew uninstall --ignore-dependencies usbmuxd
brew install --HEAD usbmuxd
brew unlink usbmuxd
brew link usbmuxd
brew install --HEAD libimobiledevice
brew install ideviceinstaller
• ios-deploy 2.0.0
✗ ios-deploy out of date (1.9.4 is required). To upgrade with Brew:
brew upgrade ios-deploy
• CocoaPods version 1.5.3
[✓] Android Studio (version 3.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 31.3.1
• Dart plugin version 181.5656
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
[✓] IntelliJ IDEA Community Edition (version 2019.1)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 34.0.4
• Dart plugin version 191.6183.88
[✓] Connected device (2 available)
• Miguel’s iPhone • 98b2b39514d586ebac7ee0537c84a7b23f8e46de • ios • iOS 12.2
• iPhone Xʀ • C140849E-3078-4185-B796-5FED4FCFE5EE • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)
! Doctor found issues in 1 category.