Skip to content

Engine often does not correctly handle errors from the Dart embedding API #30407

@rmacnak-google

Description

@rmacnak-google

The DART_CHECK_VALID macro had incorrect behavior in the face of Isolate.kill and Dart_Cleanup. It was removed upstream.

The engine is still in maybe places calling Dart_PropagateError in a context where is not Dart frame to which the error can be propagated. One example is the initialization of the core libraries that happens in the isolate creation callback.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listdependency: dartDart team may need to help usengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions