Skip to content

firebase_auth: verifyPhoneNumber should not sign in #22304

@kdy1

Description

@kdy1

I want to link phone number to my user's account.

But I can't as verifyPhoneNumber implicitly signs in on native side.
https://github.com/flutter/plugins/blob/6341d3a5c7b36194ab0fd50a839b363579c3eb37/packages/firebase_auth/android/src/main/java/io/flutter/plugins/firebaseauth/FirebaseAuthPlugin.java#L161-L176

To be consistent with other methods, it should instead return Future<sms code>, and report verificationId with callback as it might be expired while waiting for the code sent.

/// 
Future<String> verifyPhoneNumber({
  @required String phoneNumber,
  @required Duration timeout,
  int forceResendingToken,
  @required PhoneCodeSent codeSent,
  @required PhoneCodeAutoRetrievalTimeout codeAutoRetrievalTimeout,
}) async {}

Future<FirebaseUser> signInWithPhoneNumber({
  @required String verificationId,
  @required String smsCode,
}) async {}

Future<FirebaseUser> linkWithPhoneNumber({
  @required String verificationId,
  @required String smsCode,
}) async {

But this is breaking change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    p: firebaseFirebase pluginsp: firebase_authThe Firebase Auth pluginpackageflutter/packages repository. See also p: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions