Repository navigation
[flutter_tools] ErrorHandlingFile.readAsStringSync drops encoding parameter #196225
Description
ErrorHandlingFile.readAsStringSync({Encoding encoding = utf8}) ignores its encoding parameter and calls delegate.readAsStringSync(), forcing UTF-8 decoding even when callers specify another codec (unlike readAsString, readAsLines, and readAsLinesSync, which forward encoding).
Because flutter_tools wraps LocalFileSystem in ErrorHandlingFileSystem, callers such as ScreenshotCommand.ensureOutputIsNotJsonRpcError (which passes encoding: const AsciiCodec(allowInvalid: true) when checking small screenshot files for JSON-RPC error payloads) crash with FileSystemException: Failed to decode data using encoding 'utf-8':
FileSystemException: Failed to decode data using encoding 'utf-8', path = '.../flutter_01.skp'
#0 _File._tryDecode (dart:io/file_impl.dart:704:7)
#1 _File.readAsStringSync (dart:io/file_impl.dart:715:7)
#2 ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:99:16)
#3 ErrorHandlingFile.readAsStringSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:258:22)
#4 _runSync (package:flutter_tools/src/base/error_handling_io.dart:1116:16)
#5 ErrorHandlingFile.readAsStringSync (package:flutter_tools/src/base/error_handling_io.dart:257:12)
#6 ScreenshotCommand.ensureOutputIsNotJsonRpcError (package:flutter_tools/src/commands/screenshot.dart:198:39)
#7 ScreenshotCommand.runSkia (package:flutter_tools/src/commands/screenshot.dart:180:5)
Activity
[flutter_tools] Forward encoding in ErrorHandlingFile.readAsStringSync (