Skip to content

Consolidate exit-code parameters on runCommand in dev/bots/run_command.dart #196126

Description

@andywolff

#195708 introduced checkExitCode in runCommand in dev/bots/run_command.dart, so now we have three separate exit-code parameters: checkExitCode, expectNonZeroExit, and expectedExitCode. This feels ugly and error prone. Let's migrate to something cleaner, like an enum (enum ExpectedExit { zero, nonZero, any }) or something. I filed this followup issue instead of doing it in that PR to avoid migrating callsites together with the other changes in the PR.

Activity

  1. self-assigned this
    on Nov 6, 2026
  2. added
    team-toolOwned by Flutter Tool team
    team-infraOwned by Infrastructure team
    and removed
    team-infraOwned by Infrastructure team
    team-toolOwned by Flutter Tool team
    on Nov 9, 2026
  3. eyebrowsoffire commented on Nov 9, 2026

    @eyebrowsoffire
    Contributor

    This isn't really infra, but this code doesn't really have a single owner. I'll assign P2 here.

  4. added
    P2Important issues not at the top of the work list
    triaged-infraTriaged by Infrastructure team
    on Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions