You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consolidate exit-code parameters on runCommand in dev/bots/run_command.dart #196126
#195708 introduced checkExitCode in runCommand in dev/bots/run_command.dart, so now we have three separate exit-code parameters: checkExitCode, expectNonZeroExit, and expectedExitCode. This feels ugly and error prone. Let's migrate to something cleaner, like an enum (enum ExpectedExit { zero, nonZero, any }) or something. I filed this followup issue instead of doing it in that PR to avoid migrating callsites together with the other changes in the PR.
Activity
eyebrowsoffire commentedon Nov 9, 2026
This isn't really infra, but this code doesn't really have a single owner. I'll assign P2 here.