Skip to content

Remove setFloat usage from the framework #195358

Closed
Closed
Remove setFloat usage from the framework#195358
Labels
P1High-priority issues at the top of the work listteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@gaaclarke
gaaclarke
opened on Oct 26, 2026

The named variants should be used now (ex getUniformFloat). InkSparkle and StretchEffect both use the old API.

Activity

  1. gaaclarke
    added a parent issue on Oct 26, 2026
  2. gaaclarke
    added
    P1High-priority issues at the top of the work list
    team-engineOwned by Engine team
    on Oct 26, 2026
  3. github-project-automation
    added this to Flutter Engine Focuson Oct 26, 2026
  4. github-project-automation
    moved this to Todo in Flutter Engine Focuson Oct 26, 2026
  5. github-project-automation
    moved this from Todo to In progress in Flutter Engine Focuson Oct 26, 2026
  6. gaaclarke
    added
    triaged-engineTriaged by Engine team
    on Nov 2, 2026
  7. auto-submit
    added a commit that references this issue on Nov 2, 2026

    [material_ui] Use named uniforms instead of setFloat in InkSparkle (#…

    30d67e6
  8. Leapward-Koex
    added a commit that references this issue on Nov 3, 2026

    Use named uniforms instead of setFloat in StretchEffect (flutter#195372)

    852534a
  9. gmackall
    added a commit that references this issue on Nov 3, 2026

    Use named uniforms instead of setFloat in StretchEffect (flutter#195372)

    bbdbf0f

  10. gaaclarke commented on Nov 5, 2026

    @gaaclarke
    gaaclarke
    on Nov 5, 2026
    MemberAuthor

    I'm pretty sure this is done now after flutter/packages#13445 and #195372, correct me if I'm wrong @mohamedalsamrai

  11. gaaclarke
    closed this as completedon Nov 5, 2026
  12. github-project-automation
    moved this from In progress to Done in Flutter Engine Focuson Nov 5, 2026

  13. mohamedalsamrai commented on Nov 5, 2026

    @mohamedalsamrai
    mohamedalsamrai
    on Nov 5, 2026
    Contributor

    I'm pretty sure this is done now after flutter/packages#13445 and #195372, correct me if I'm wrong @mohamedalsamrai

    Yes, that's right, thanks The only calls left are in the frozen Material copy of InkSparkle in this repo (packages/flutter/lib/src/material/ink_sparkle.dart), which I left as is because of the freeze. Its material_ui copy was migrated in flutter/packages#13445.

  14. gaaclarke commented on Nov 5, 2026

    @gaaclarke
    gaaclarke
    on Nov 5, 2026
    MemberAuthor

    Okay, hopefully we can gracefully merge the deprecation. I'm still feeling out this whole split of the packages. Thanks.

  15. gmackall
    added a commit that references this issue on Nov 5, 2026

    Deprecates setFloat API (flutter#195505)

    451069b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work listteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions