[google_sign_in] handleOpen should not be a public API #194462

Activity

1. hellohuanlin

   added

   platform-iosiOS applications specificallyiOS applications specifically

   team-iosOwned by iOS platform teamOwned by iOS platform team

   p: google_sign_inThe Google Sign-In pluginThe Google Sign-In plugin

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   triaged-iosTriaged by iOS platform teamTriaged by iOS platform team

   on Oct 15, 2026
2. jmagman

   assigned

   victogomez-cs

   on Oct 15, 2026
3. victogomez-cs commented on Oct 15, 2026

   

   victogomez-cs

   on Oct 15, 2026

   Last edited by victogomez-cs

   More actions

   On iOS this is correct: handleOpen is only a helper for scene URL handling, so it should not be public.

   The original Obj-C split this by platform:

   • iOS used application:openURL:options: and a test-only handleURLs: helper from scene:openURLContexts:
   • macOS implemented FlutterAppLifecycleDelegate.handleOpenURLs:

   On macOS, handleOpen(_:) has to stay public. That is Swift’s import of handleOpenURLs:. Making it internal fails to compile (must be declared public because it matches a requirement in public protocol 'FlutterAppLifecycleDelegate').

   Plan:

   • Keep public handleOpen on macOS only, as the protocol witness
   • Remove the iOS handleOpen helper
   • Share GID URL forwarding in an internal handleURLs helper used by iOS scene handling and tests
   • Leave application(_:open:options:) on iOS unchanged
4. auto-submit

   closed this as completedin fee0bbfon Oct 15, 2026
5. jmagman

   added a commit that references this issue on Oct 15, 2026

   [google_sign_in] Remove the public iOS handleOpen helper (flutter#13273)

   ...

   fee0bbf
6. github-actions commented on Oct 29, 2026

   

   github-actionsBot

   on Oct 29, 2026 – with GitHub Actions

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
7. github-actions

   locked as resolved and limited conversation to collaborators on Oct 29, 2026