Skip to content

[camera]missing a return after flutterError #194348

New issue
New issue
Open
Open
[camera]missing a return after flutterError#194348
Labels
P2Important issues not at the top of the work listplatform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtriaged-iosTriaged by iOS platform team

Description

@hellohuanlin
hellohuanlin
opened on Oct 14, 2026

Steps to reproduce

Gemini caught it in my PR: flutter/packages#13248

https://github.com/flutter/packages/blame/ac2db9cfeaf69c5064739e0d477ef8cb9c19cd35/packages/camera/camera_avfoundation/darwin/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift#L1250-L1257

This is missing a return in the if

CC @RobertOdrowaz

Expected results

NA

Actual results

NA

Code sample

NA

Screenshots or Video

NA

Logs

NA

Flutter Doctor output

NA

Activity

  1. hellohuanlin
    added
    platform-iosiOS applications specifically
    fyi-ecosystemFor the attention of Ecosystem team
    team-iosOwned by iOS platform team
    on Oct 14, 2026

  2. hellohuanlin commented on Oct 14, 2026

    @hellohuanlin
    hellohuanlin
    on Oct 14, 2026
    ContributorAuthor

    Please also note that simply adding return doesn't balance out the beginConfiguration(). Will need a commitConfiguration before the return.

  3. vashworth
    added
    P2Important issues not at the top of the work list
    triaged-iosTriaged by iOS platform team
    on Oct 14, 2026
  4. Piinks
    added
    triaged-ecosystemTriaged by Ecosystem team
    on Oct 20, 2026
  5. flutter-triage-bot
    removed
    fyi-ecosystemFor the attention of Ecosystem team
    triaged-ecosystemTriaged by Ecosystem team
    on Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listplatform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtriaged-iosTriaged by iOS platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions