Repository navigation
[Google_sign_in] Consider removing the objc exception handler from the plugin #193464
Description
Extracted from: https://github.com/flutter/packages/pull/12658/changes#r4018994922
Do we actually need ExceptionCatcher.m?
From what I see, the only exceptions the SDK ever throws are invalid arguments:
Missing GIDClientID, which means the app hasn't been configured correctly and won't work (can't happen unexpectedly in the wild for an app; it's a deterministic failure that can only happen if the app was build wrong).
Missing URL scheme handling, same restrictions.
Missing clientID, same restrictions.
Missing view controller, which appears to only be possible if we pass a null view controller into a non-nullable parameter, which a) would be a plugin bug, and b) is something we would have to try very hard to screw up with a Swift implementation of the plugin.
So AFAICT, the three that could happen to clients are all cases where the client built their app incorrectly, and would be found by the client with any testing of the login path. Is it actually worth keeping the plugin hybrid language forever just to make that category of error bubble up to Dart instead of crashing?
Activity
LongCatIsLooong commentedon Sep 28, 2026
Also /cc @cbracken for opinions
cbracken commentedon Oct 1, 2026
This proposal seems reasonable to me.
jmagman commentedon Oct 1, 2026
@victogomez-cs can you add this follow-up to flutter/packages#12658 to your pile of google_sign_in work?
[google_sign_in] Remove the Objective-C exception catcher (flutter#13156
github-actions commentedon Oct 27, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.