-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
Issue by Hixie
Thursday Oct 08, 2015 at 18:28 GMT
Originally opened as https://github.com/flutter/engine/issues/1544
When you want to add or remove gesture detection, it's intuitive to think that the following should all be equivalent:
- Having a test in the handlers.
- Having a test in the build function that decides whether to set the handlers.
- Having a test in the build function that decides whether to have a GestureDetector at all.
- Having a test in the build function that decides whether to have a GestureDetector at all, where the child of the GestureDetector is a KeyedSubtree with a
new GlobalObjectKey(this).
The first two and the fourth are in fact equivalent (the second is slightly slower, the fourth slightly slower still), but the third is not. The third will cause all kinds of state to drop.
We should fix that. Until we do, we should document the heck out of it.
Metadata
Metadata
Assignees
Labels
c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.